BUGFIX: cloud toPolicy SAN regex processing #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inteon
requested review from
rvelaVenafi,
marcos-albornoz,
luispresuelVenafi and
EduardoVV
as code owners
inteon
force-pushed
the
fix_config
branch
2 times, most recently
from
7421879 to
650c8af
Compare
inteon
force-pushed
the
fix_config
branch
2 times, most recently
from
2faedd8 to
d80273f
Compare
inteon
commented
Apr 5, 2024
inteon
changed the title
|
@inteon can you please rebase your branch? |
Done |
rvelaVenafi
approved these changes
Apr 26, 2024
inteon
force-pushed
the
fix_config
branch
2 times, most recently
from
881d551 to
5f367a2
Compare
sbanic-venafi
approved these changes
Apr 30, 2024
marcos-albornoz
approved these changes
Apr 30, 2024
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
|
I re-signed the commits, since the signature got lost when I clicked the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addStartEndToArrayfunction was missing for thep.IpSanRegExsp.EmailSanRegExsct.SanRfc822NameRegexesandct.SanUniformResourceIdentifierRegexesfields.addStartEndToArrayalso changed the policy because it created an empty slice for a nil input (instead of just returning nil instead).