Resolve security vulnerabilities from audit competition #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues have been addressed in this PR:
approve
will impactDepositBatch
for USDT token when multi-chain deployment active hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#3indexed
Keyword in Events Causes Data Loss for Dynamic Array Variables hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#25_minMintAmount
hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#31TokenWhitelistManagement
implementation hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#33tokenExclusionManager
or Last user unable toclaimRemovedTokens
hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#74claimRemovedTokens
loop due to potential large gap betweenlastClaimedUserId
and_currentSnapshotId
hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#75PortfolioInfolList
hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#83_currentSnapshotId()
is neither initialized nor updated across the protocol hats-finance/Velvet-Capital-0x0bb0c08fd9eeaf190064f4c66f11d18182961f77#89And some additional findings as described here: https://docs.google.com/spreadsheets/d/1PfoCQ3YUyv4KzAbTx0Vf_0k3zv_gE_gIsOKcSiNySa0/edit?gid=1450388054#gid=1450388054