Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample_size visualization and update notebooks #667

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

a-kore
Copy link
Collaborator

@a-kore a-kore commented Jul 24, 2024

Feature

  • Add sample size visualization to plots in
    image

Short Description

  • Add visualization of sample through size of marker (w/ tranparency of 0.3).
  • Add method to report API for processing multiple performance metrics (log_performance_metrics).
  • Update notebooks to use new method.

Tests Added

  • test_log_performance_metrics

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.22%. Comparing base (269b6ec) to head (15f461f).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   75.14%   75.22%   +0.08%     
==========================================
  Files         128      128              
  Lines       11524    11542      +18     
==========================================
+ Hits         8660     8683      +23     
+ Misses       2864     2859       -5     
Files Coverage Δ
cyclops/report/model_card/fields.py 93.95% <100.00%> (+0.08%) ⬆️
cyclops/report/report.py 78.46% <100.00%> (+5.64%) ⬆️
cyclops/evaluate/evaluator.py 22.34% <0.00%> (-0.25%) ⬇️
cyclops/evaluate/fairness/evaluator.py 13.02% <0.00%> (ø)
cyclops/report/utils.py 87.15% <66.66%> (-0.99%) ⬇️

Impacted file tree graph

@a-kore a-kore requested a review from fcogidi July 24, 2024 18:31
@a-kore a-kore enabled auto-merge (squash) July 24, 2024 19:10
@a-kore a-kore merged commit 332898e into main Jul 24, 2024
12 checks passed
@a-kore a-kore deleted the sample_size_visualization branch July 24, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants