Integrate experimental metrics with other modules #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcogidi
added
the
refactor
|
@amrit110 Please take a look at the docs build. PS: Welcome back! :) |
|
@fcogidi thanks :). Fixed the issue with the notebook kernel. Think there is some other error now, seems to be in the plotting function. |
amrit110
approved these changes
Jan 29, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 70.50% 70.71% +0.21%
==========================================
Files 124 126 +2
Lines 11106 11224 +118
==========================================
+ Hits 7830 7937 +107
- Misses 3276 3287 +11
|
rjavadi
pushed a commit
that referenced
this pull request
Jan 30, 2024
* integrate experimental metrics with other modules * add average precision metric to experimental metrics package * fix tutorials * Add type hints and keyword arguments to metrics classes * Update nbsphinx version to 0.9.3 * Update nbconvert version to 7.14.2 * Fix type annotations and formatting issues * Update kernel display name in mortality_prediction.ipynb * Add guard clause to prevent module execution on import * Update `torch_distributed.py` with type hints * Add multiclass and multilabel average precision metrics * Change jupyter kernel * Fix type annotations for metric values in ClassificationPlotter --------- Co-authored-by: Amrit K <amritk@vectorinstitute.ai>
amrit110
added a commit
that referenced
this pull request
Feb 11, 2024
* Changed documentation theme to sphinx-book-theme * Added details about Pandoc requirment * Added initial document for accuracy.py * Fix pre-commit hook errors * Added confusion matrix doc * Add auroc doc and fix titles * Add average precision docs * Added more documents for metrics * Add index for user guide in side bar * Minor patches (#542) * Fix capitalization of Python * Change ValueError to TypeError and update docstrings * Add Precision-Recall Curve to experimental metrics (#544) * Add ROC curve (#545) * Add ROC metrics to experimental module * fix typo * Fix docstrings * Add AUROC (#546) * Add AUROC metric to experimental module * Refactor binary and multiclass ROC functions * Refactor tests to use a common thresholds list * Fix mypy error * Add regression metrics (#547) * Add regression support * update docstrings * Ignore `no-any-return` errors * Integrate experimental metrics with other modules (#549) * integrate experimental metrics with other modules * add average precision metric to experimental metrics package * fix tutorials * Add type hints and keyword arguments to metrics classes * Update nbsphinx version to 0.9.3 * Update nbconvert version to 7.14.2 * Fix type annotations and formatting issues * Update kernel display name in mortality_prediction.ipynb * Add guard clause to prevent module execution on import * Update `torch_distributed.py` with type hints * Add multiclass and multilabel average precision metrics * Change jupyter kernel * Fix type annotations for metric values in ClassificationPlotter --------- Co-authored-by: Amrit K <amritk@vectorinstitute.ai> * Changed documentation theme to sphinx-book-theme * Don't update deps * Pre-commit fixes * Add doc for ROC Curve * Fix footer in docs * Bump to 0.2.3 Signed-off-by: Amrit Krishnan <amrit110@gmail.com> * Add logo and css fixes * Fix formatting of conf.py file * Small fix * Move evaluation metrics docs under API reference * Fix poetry build * Improve documentation structure * Formatting fixes --------- Signed-off-by: Amrit Krishnan <amrit110@gmail.com> Co-authored-by: Franklin <41602287+fcogidi@users.noreply.github.com> Co-authored-by: Amrit K <amritk@vectorinstitute.ai> Co-authored-by: Amrit Krishnan <amrit110@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Fix.
Short Description
Tests Added
tests/cyclops/evaluate/metrics/experimental/test_average_precision.py