Update JEI and Zeta #5045
Open
Update JEI and Zeta #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
This PR depends on changes from Zeta here:
It should only be merged after the above changes from Zeta are merged and released.
Then the PR will need to be updated to depend on that new version.
Issue:
I was looking into why Quark's extra tooltips don't apply to JEI.
I think it might have been fixed in Zeta when they replacedRequiredModTooltipHandlerin VazkiiMods/Zeta@0090b77 but that hasn't been released yet, and so Quark isn't using it.edit: I was able to fix the issue in JEI here:
I submitted PRs to Zeta and Quark to help out with some of the toil of updating these, hope it helps!