Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu 20 for workflows #2677

Merged
merged 6 commits into from
Jul 7, 2023
Merged

Use ubuntu 20 for workflows #2677

merged 6 commits into from
Jul 7, 2023

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Jul 4, 2023

Ubuntu 18 is deprecated and gives warnings, also cache vagrant boxes

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

18 and 10.15 are deprecated and give warnings
@update-docs
Copy link

update-docs bot commented Jul 4, 2023

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn
Copy link
Member Author

tomjn commented Jul 4, 2023

Looks like the MacOS 11 image doesn't have vagrant built in, do we need to use MacOS for all of them? Ubuntu might result in easier/quicker workflows with more availability

@tomjn
Copy link
Member Author

tomjn commented Jul 4, 2023

 ▷ Running after_composer hook
 * [PHPCS]: Provisioning PHP_CodeSniffer (phpcs), see https://github.com/squizlabs/PHP_CodeSniffer

In JsonFile.php line 198:
                                                                         
  The file "/home/runner/.config/composer/config.json" is not readable. 

@tomjn tomjn changed the title Use ubuntu 20 and MacOS 11 for workflows Use ubuntu 20 for workflows Jul 7, 2023
@tomjn tomjn requested a review from a team July 7, 2023 15:42
@tomjn
Copy link
Member Author

tomjn commented Jul 7, 2023

I'm leaving the MacOS issue for another time as this change lets us do basic tests with Ubuntu 20

@tomjn tomjn merged commit c2917c6 into develop Jul 7, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant