Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust wp cli package updating so it doesn't fail the provisioner #2601

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Adjust wp cli package updating so it doesn't fail the provisioner #2601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f50b734
adjust wp cli package updating so it doesn't fail the provisioner
tomjn Apr 20, 2022
953f3e4
Update CHANGELOG.md
tomjn Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ permalink: /docs/en-US/changelog/

# Changelog

## 3.10 ( 2022 TBD )

### Enhancements

### Bug Fixes

* WP CLI package update failures now fail gracefully instead of stopping a provision ( #2601 )

## 3.9.1 ( 2022 April 13th )

### Enhancements
Expand Down
7 changes: 5 additions & 2 deletions provision/core/wp-cli/provision.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,11 @@ function wp_cli_setup() {

if [ "${VVV_DOCKER}" != 1 ]; then
vvv_info " * [WP-CLI]: Updating packages"
noroot wp package update
vvv_info " * [WP-CLI]: Package updates completed"
if noroot wp package update; then
vvv_info " * [WP-CLI]: Package updates completed"
else
vvv_warn " ! [WP-CLI]: Package update did not complete, wp package update exited with a bad error code ${?}"
fi
fi

vvv_success " * [WP-CLI]: WP CLI setup completed"
Expand Down