Feature/strategy equal parts #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saantim
requested review from
ovr4ulin,
gabokatta and
MegaRedHand
and removed request for
ovr4ulin and
gabokatta
MegaRedHand
reviewed
Jun 16, 2024
| @@ -88,7 +89,7 @@ class RecurringSpending(Base): | |||
| owner_id = Column(ForeignKey("users.id")) | |||
| group_id = Column(ForeignKey("groups.id")) | |||
| category_id = Column(ForeignKey("categories.id")) | |||
| amount = Column(Integer) | |||
| amount = Column(Float) | |||
There was a problem hiding this comment.
Debería ser un entero.
|
|
||
| class Distribution(TypedDict): | ||
| user_id: int | ||
| value: float |
There was a problem hiding this comment.
Que sea un int entre 0 y 100
src/schemas.py
Outdated
|
|
||
| class UniqueSpendingBase(BaseModel): | ||
| amount: int | ||
| description: str | ||
| date: Optional[datetime] = Field(None) | ||
| group_id: int | ||
| category_id: int | ||
| strategy_data: Optional[List[Distribution]] = Field(None) |
There was a problem hiding this comment.
Podemos moverlo a CreateUniqueSpending, y no guardarlo en la DB
3 tasks
ovr4ulin
previously approved these changes
Jun 17, 2024
ovr4ulin
approved these changes
Jun 18, 2024
|
Agregar los test para los distintos tipos de gastos |
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.