Feat: add modify category #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MegaRedHand
reviewed
May 29, 2024
| return db.query(models.Category).filter(models.Category.group_id == group_id, models.Category.name == category_name).first() | ||
|
|
||
| def update_category(db: Session, category: models.Category, put_category: schemas.CategoryUpdate): | ||
| category.name=put_category.new_name |
There was a problem hiding this comment.
Sqlalchemy actualiza el nombre en todos los lugares que referencian la categoría?
Comment on lines
+51
to
+52
| class CategoryUpdate(BaseModel): | ||
| name: str |
There was a problem hiding this comment.
Y si le metemos un ID? Creo que así queda más simple
| @@ -107,6 +107,15 @@ def list_group_categories(db: DbDependency, group_id: int): | |||
|
|
|||
| return categories | |||
|
|
|||
| @app.put("/category", status_code=HTTPStatus.OK) | |||
There was a problem hiding this comment.
Estamos pasando la primary key como path parameter en estos casos.
Suggested change
| @app.put("/category", status_code=HTTPStatus.OK) | |
| @app.put("/category/{category_name}") |
|
Vamos a mergear, pero queda pendiente el siguiente cambio: #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.