Skip to content

Commit

Permalink
Revert "Revert "HACK: advapi32: Use steamuser as Wine username""
Browse files Browse the repository at this point in the history 
This reverts commit e8b512a.
  • Loading branch information
@aeikum
aeikum committed Aug 20, 2018
1 parent e8b512a commit c31fff3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dlls/advapi32/advapi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ GetUserNameA( LPSTR lpszName, LPDWORD lpSize )
BOOL WINAPI
GetUserNameW( LPWSTR lpszName, LPDWORD lpSize )
{
const char *name = wine_get_user_name();
const char *name = "steamuser"/*wine_get_user_name()*/;
DWORD i, len = MultiByteToWideChar( CP_UNIXCP, 0, name, -1, NULL, 0 );
LPWSTR backslash;

Expand Down

11 comments on commit c31fff3

@Rosuav
Copy link

@Rosuav Rosuav commented on c31fff3 Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the git revolving door 👍

@OdinVex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...So this is why my games keep seeing me as steamuser instead of me. :grumpy:

@aeikum
Copy link
Collaborator Author

@aeikum aeikum commented on c31fff3 Dec 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OdinVex Unfortunately, yes, for now. What games do you see "steamuser" in? We have an internal bug for tracking this, I can add them as test-cases for when we try to fix it.

@OdinVex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OdinVex Unfortunately, yes, for now. What games do you see "steamuser" in? We have an internal bug for tracking this, I can add them as test-cases for when we try to fix it.

All that use the API, plus numerous non-Steam games. -_- Took an hour to track this down in cross-platform development. I've no idea why this was even necessary in the first place...

@aeikum
Copy link
Collaborator Author

@aeikum aeikum commented on c31fff3 Dec 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if you could specifically name some affected games so we can test them when we have a fix.

There's more discussion of the issue over at ValveSoftware/Proton#605. It would be nice to get this fixed, yes.

@OdinVex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if you could specifically name some affected games so we can test them when we have a fix.

There's more discussion of the issue over at ValveSoftware/Proton#605. It would be nice to get this fixed, yes.

You'd only need to undo this commit, as I have, or allow maybe an environmental variable to override it. Perhaps even use the Steam login name or account ID.

@aeikum
Copy link
Collaborator Author

@aeikum aeikum commented on c31fff3 Dec 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were actually that easy, we'd have done it :)

@OdinVex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were actually that easy, we'd have done it :)

Worked for me. * shrug *

@Patola
Copy link

@Patola Patola commented on c31fff3 Dec 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OdinVex please tell the names of the games, don't just "all that X and Y"

@Gater73
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the issue in Arma 3 Proton Experimental

@OdinVex
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the issue in Arma 3 Proton Experimental

I simply run a personal repo of VS/W without this patch and have no issues since.

Please sign in to comment.