Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HL1 Client] room_type stuck and stopsound needed applied #1144

Closed
APGRoboCop opened this issue May 17, 2013 · 5 comments
Closed

[HL1 Client] room_type stuck and stopsound needed applied #1144

APGRoboCop opened this issue May 17, 2013 · 5 comments
Labels

Comments

@APGRoboCop
Copy link

Hello when I play any HL1 mod with a echo Sound environment where the map goes to room_type 1 or 9 it stays like that where the sounds echo a bit but won't go back to the default room_type 0 for some reason, when I load nextmap on my HLDM SteamCMD server when datacore map gave me that room_type 9. Now I vaguely remember this occurs on some of the CS 1.6 and TFC like that shutdown2 train sound where I had to stop the annoy train noise repeating by typing "stopsound" in console.

Is there a way of execing the cfg automatically like autoexec.cfg "stopsound" or "room_type 0" used when loading nextmap?

@alfred-valve
Copy link
Contributor

Got a way to reproduce this?

@ghost ghost assigned alfred-valve May 18, 2013
@ghost
Copy link

ghost commented May 18, 2013

#299
In Counter-Strike 1.6:

] room_type
"room_type" is "0"
] map cs_siege
] room_type
"room_type" is "22"
] disconnect
] room_type
"room_type" is "22"
] map de_dust
] room_type
"room_type" is "22"

If I get it right, room_type variable changes only when it's defined in a map.
When it's not defined, room_type should be 0, but if it was changed before, it stays as is.
So
on disconnect room_type shoud be changed to 0
on changelevel room_type should be changed to defined in a map value or to 0, if it wasn't defined

@alfred-valve
Copy link
Contributor

I see the issue, when you connect to a map we don't tell the client what the current room type is, I'll fix that.

@APGRoboCop
Copy link
Author

Thanks a lot Alfred, that means a lot. And I'll keep in touch for any rare/hidden bugs from my Linux HLDS SteamPipe server.

@mikela-valve mikela-valve removed this from the Next Release milestone Apr 23, 2019
@SamVanheer
Copy link

Was this actually fixed? I tested this with a dedicated server (vanilla HL and CS) and the room_type cvar did not reset. I also can't find anything sending a room_type 0 command or equivalent user message.

There is this line:

CVAR_SET_STRING("room_type", "0");// clear DSP

But that's always been there. It resets the setting in singleplayer as expected. It does not work when connected to a dedicated server.

SamVanheer added a commit to twhl-community/halflife-updated that referenced this issue Aug 4, 2022
…t, reset room_type to 0 on map change, save room_type and restore it when loading same map

Resolves ValveSoftware/halflife#1144
Resolves ValveSoftware/halflife#2936
SamVanheer added a commit to twhl-community/halflife-updated that referenced this issue Aug 5, 2022
hammermaps added a commit to sohl-modders/Updated-SOHL-1.2 that referenced this issue Apr 26, 2023
…lt, reset room_type to 0 on map change, save room_type and restore it when loading same map

Resolves ValveSoftware/halflife#1144
Resolves ValveSoftware/halflife#2936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants