Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need cmake to "install" cert tool to proper location #186

Closed
ELKABILLA opened this issue Aug 7, 2021 · 5 comments
Closed

Need cmake to "install" cert tool to proper location #186

ELKABILLA opened this issue Aug 7, 2021 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@ELKABILLA
Copy link

ELKABILLA commented Aug 7, 2021 •
edited
Loading

When running the 'vcpkg' building, i was looking to the tests provided and realized that steamnetworkingsockets_certtool.exe was missing, GameNetworkingSockets.dll althougt was sucessfully created. So i have a simple question:
-- Is this behaviour intended on purpose or it has not been included into this build proccess ?
Thanks in advance.

Building on Windows x64
@zpostfacto
Copy link
Contributor

I don't think anybody outside of Valve has used any of the PKI, to be honest. So this tool (and the PKI) does work, because we use it -- but you should know that you might be one of the first people to actually use it outside of Valve.

We probably should have a way to build it in cmake.

@ELKABILLA
Copy link
Author

ELKABILLA commented Aug 11, 2021 •
edited
Loading

yes you're right indeed, i see your point.
I was just wondering why it is being referenced in these tests if it doesnt build automatically in the project.
so i think my doubt has been clarified.

@zpostfacto zpostfacto added the help wanted Extra attention is needed label Oct 4, 2021
@zpostfacto
Copy link
Contributor

zpostfacto commented Oct 4, 2021 •
edited
Loading

Added the help wanted label. This should be a pretty straightforward job for anybody with basic cmake knowledge.

zpostfacto added a commit that referenced this issue Nov 15, 2021
@zpostfacto
Tweaking cmake options
29925ce 
Added MSVC_CRT_STATIC option.  Defaults to off.  Should help with linking
against protobuf or other situations.

Added BUILD_STATIC_LIB and BUILD_SHARED_LIB options.  (Fixes issue #191)

I think I probably also need to add an option to build the cert tool
and maybe package it up, too (issue #186) but that isn't included
in this change.
zpostfacto added a commit that referenced this issue Nov 24, 2021
@zpostfacto
Got cert tool building
5c793b9 
This is progress towards fixing #186.  However, I need some help
publishing/installing (or whatever it's called) properly, and
there is probably a better way to integrate with picojson than
using a git submodule.
@zpostfacto
Copy link
Contributor

You can now build the cert tool by initializing the picojson git submodule and passing -DBUILD_TOOLS=ON to cmake. I could use some help from somebody who knows cmake and/or vcpkg to "publish/install" the tool in the appropriate place and integrate with vcpkg better.

@zpostfacto
Copy link
Contributor

OK, dc80d53 fixes a compile issue on Windows.

The vcpkg.info file has a "feature" for tools.

So I think the last step is just that I just need to know the proper way to "install" the tool. Changing the title of this bug to reflect what is missing.

@zpostfacto zpostfacto changed the title [Question] Building via 'vcpkg' missing steamnetworkingsockets_certtool.exe ? Need cmake to "install" cert tool to proper location Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zpostfacto @ELKABILLA