-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix, Urgent: Fix soft-overwrite preventing other mods' mobs from despawning with special conditions. #907
Minor fix, Urgent: Fix soft-overwrite preventing other mods' mobs from despawning with special conditions. #907
Conversation
Replace soft-overwrite Inject with compatible ModifyArg so we don't stop every other mob from despawning if we encounter an error.
Rename method
This code crashes when I try running it |
I'll take a look, it's possible I got the args wrong. |
I think this would work, tho I havent tested it
|
I merged the updated fix in dcba513 |
Nevermind, I misunderstood the problem In that case, do what SmoothChunkLoading does and mix into |
…m despawning with special conditions. (ValkyrienSkies#907) * Update MixinPersistentEntitySectionManager.java Replace soft-overwrite Inject with compatible ModifyArg so we don't stop every other mob from despawning if we encounter an error. * Update MixinPersistentEntitySectionManager.java Rename method
Replaces a soft-overwrite Inject with a ModifyArg that does the same thing and doesn't prevent other Mixins targeting this method from firing.