Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather 2 wind & storm affecting ships #897

Merged

Conversation

alex-s168
Copy link
Contributor

(identical to #896 but removed the other git author (which was me))

The values in the config should be adjusted a bit

@StewStrong
Copy link
Member

Can you modify the code to only run if Weather2 is installed? Right now it seems like this will crash if someone uses VS2 without Weather2.

@alex-s168
Copy link
Contributor Author

There is a if (!LoadedMods.weather2) return in the function
I'm pretty sure that the jvm only loads classes (in this case weather2) when it is used in the code

@alex-s168
Copy link
Contributor Author

@StewStrong moved it anyways because nicer code

@StewStrong StewStrong merged commit 6809a80 into ValkyrienSkies:1.18.x/main Jul 26, 2024
5 checks passed
@StewStrong
Copy link
Member

Nice! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants