Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status apply #15

Closed

Conversation

lburgazzoli
Copy link

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (initialize_api@9f5e312). Learn more about missing BASE report.

Files with missing lines Patch % Lines
controllers/components/dashboard_controller.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##             initialize_api      #15   +/-   ##
=================================================
  Coverage                  ?   19.05%           
=================================================
  Files                     ?       43           
  Lines                     ?     2986           
  Branches                  ?        0           
=================================================
  Hits                      ?      569           
  Misses                    ?     2350           
  Partials                  ?       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli
Copy link
Author

@VaishnaviHire this fixes the apply problem (the message was misleading and the actual failure was on the status update) and add some small ux improvement, like see the status and reason in the kubectl get:

➜ kubectl get dashboards.components.opendatahub.io
NAME                READY   REASON
default-dashboard   True    Ready

@VaishnaviHire
Copy link
Owner

Closing this I cherry-picked the commits with minor additional changes

@lburgazzoli lburgazzoli deleted the fix_status_apply branch October 17, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants