Skip to content

Commit

Permalink
disable: modelmesh-monitoring (opendatahub-io#681)
Browse files Browse the repository at this point in the history
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit c88d84d)
  • Loading branch information
zdtsw authored and VaishnaviHire committed Nov 15, 2023
1 parent e59cf04 commit 24928f2
Showing 1 changed file with 9 additions and 14 deletions.
23 changes: 9 additions & 14 deletions components/modelmeshserving/modelmeshserving.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ import (
)

var (
ComponentName = "model-mesh"
Path = deploy.DefaultManifestPath + "/" + ComponentName + "/overlays/odh"
monitoringPath = deploy.DefaultManifestPath + "/" + "modelmesh-monitoring/base"
ComponentName = "model-mesh"
Path = deploy.DefaultManifestPath + "/" + ComponentName + "/overlays/odh"
// monitoringPath = deploy.DefaultManifestPath + "/" + "modelmesh-monitoring/base"
DependentComponentName = "odh-model-controller"
DependentPath = deploy.DefaultManifestPath + "/" + DependentComponentName + "/base"
)
Expand Down Expand Up @@ -140,17 +140,12 @@ func (m *ModelMeshServing) ReconcileComponent(cli client.Client, owner metav1.Ob
if err != nil {
return err
}
var monitoringNamespace string
if dscInit.Spec.Monitoring.Namespace != "" {
monitoringNamespace = dscInit.Spec.Monitoring.Namespace
} else {
monitoringNamespace = dscispec.ApplicationsNamespace
}

// If modelmesh is deployed successfully, deploy modelmesh-monitoring
if err = deploy.DeployManifestsFromPath(cli, owner, monitoringPath, monitoringNamespace, ComponentName, enabled); err != nil {
return err
}
// var monitoringNamespace string
// if dscInit.Spec.Monitoring.Namespace != "" {
// monitoringNamespace = dscInit.Spec.Monitoring.Namespace
// } else {
// monitoringNamespace = dscispec.ApplicationsNamespace
// }

// CloudService Monitoring handling
// TODO: cleanup logic in rhods-2.5
Expand Down

0 comments on commit 24928f2

Please sign in to comment.