give meaningful name to generics to avoid comment

VUnit · Dec 13, 2019 · 6f769f9 · 6f769f9
1 parent 07ee40c
commit 6f769f9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/vunit/vhdl/verification_components/run.py b/vunit/vhdl/verification_components/run.py
@@ -134,9 +134,9 @@ def gen_avalon_master_tests(obj, *args):
 
 tb_axi_stream = lib.test_bench("tb_axi_stream")
 for test in tb_axi_stream.get_tests("test random stall on master"):
-    test.add_config(name="stall_master", generics=dict(g_stall_master=30))
+    test.add_config(name="stall_master", generics=dict(g_stall_percentage_master=30))
 
 for test in tb_axi_stream.get_tests("test random stall on slave"):
-    test.add_config(name="stall_slave", generics=dict(g_stall_slave=30))
+    test.add_config(name="stall_slave", generics=dict(g_stall_percentage_slave=30))
 
 ui.main()
diff --git a/vunit/vhdl/verification_components/test/tb_axi_stream.vhd b/vunit/vhdl/verification_components/test/tb_axi_stream.vhd
@@ -18,19 +18,19 @@ use work.sync_pkg.all;
 
 entity tb_axi_stream is
   generic(
-    runner_cfg     : string;
-    g_id_length    : natural := 8;
-    g_dest_length  : natural := 8;
-    g_user_length  : natural := 8;
-    g_stall_master : natural range 0 to 100 := 0; -- as in 0 to 100%
-    g_stall_slave  : natural range 0 to 100 := 0; -- as in 0 to 100%
+    runner_cfg    : string;
+    g_id_length   : natural := 8;
+    g_dest_length : natural := 8;
+    g_user_length : natural := 8;
+    g_stall_percentage_master : natural range 0 to 100 := 0;
+    g_stall_percentage_slave  : natural range 0 to 100 := 0
   );
 end entity;
 
 architecture a of tb_axi_stream is
 
-  constant master_stall_config : stall_config_t := (stall_probability => real(g_stall_master)/100.0, min_stall_cycles => 5, max_stall_cycles => 15);
-  constant slave_stall_config  : stall_config_t := (stall_probability => real(g_stall_slave)/100.0, min_stall_cycles => 5, max_stall_cycles => 15);
+  constant master_stall_config : stall_config_t := (stall_probability => real(g_stall_percentage_master)/100.0, min_stall_cycles => 5, max_stall_cycles => 15);
+  constant slave_stall_config  : stall_config_t := (stall_probability => real(g_stall_percentage_slave)/100.0, min_stall_cycles => 5, max_stall_cycles => 15);
 
   constant master_axi_stream : axi_stream_master_t := new_axi_stream_master(
     data_length  => 8,