Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zip to tar function #4

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add zip to tar function #4

wants to merge 3 commits into from

Conversation

yinlinchen
Copy link
Member

JIRA Ticket: (https://webapps.es.vt.edu/jira/browse/LIBTD-2348) (:star:)

What does this Pull Request do? (:star:)

Repack Dspace zip file to tar to support Linux environment

How should this be tested?

Follow the readme.md, run the program, and verify it.

Interested parties

Tag (@jimtuttle @sindtd ) interested parties

(:star:) Required fields

@yinlinchen yinlinchen requested review from jimtuttle and sindtd October 1, 2020 14:46
Copy link
Member

@jimtuttle jimtuttle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The APTrust Bagging Requirements specify that bags must be serialized in tar format per https://aptrust.github.io/userguide/bagging/

@yinlinchen
Copy link
Member Author

yinlinchen commented Oct 1, 2020

@jimtuttle this PR did use tar and follow the APTrust Bagging Requirements. Did you actually run the program of the PR?

@yinlinchen
Copy link
Member Author

@jimtuttle
Copy link
Member

Can you please add tests for createBagit, saveToTargetFile, and createTarFile?

@sindtd
Copy link

sindtd commented Oct 8, 2020

The export from dspace wasn't working as expected, I've pushed a change that I found to work. Otherwise, I've run the script on vtechworks-dev and uploaded items this morning with the changes from Yinlin.

@yinlinchen
Copy link
Member Author

The export from dspace wasn't working as expected, I've pushed a change that I found to work. Otherwise, I've run the script on vtechworks-dev and uploaded items this morning with the changes from Yinlin.

@sindtd It looks to me that your change is just separate space to individual args in the command. BTW, your change is irrelevant to this PR. You should submit another PR for that and not just update it. Since it is your first time to do that so that's fine to me.

@jimtuttle So this PR should works as expected. Please verify and merge or let me know what else you need from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants