-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zip to tar function #4
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The APTrust Bagging Requirements specify that bags must be serialized in tar format per https://aptrust.github.io/userguide/bagging/
@jimtuttle this PR did use tar and follow the APTrust Bagging Requirements. Did you actually run the program of the PR? |
Can you please add tests for createBagit, saveToTargetFile, and createTarFile? |
The export from dspace wasn't working as expected, I've pushed a change that I found to work. Otherwise, I've run the script on vtechworks-dev and uploaded items this morning with the changes from Yinlin. |
@sindtd It looks to me that your change is just separate space to individual args in the command. BTW, your change is irrelevant to this PR. You should submit another PR for that and not just update it. Since it is your first time to do that so that's fine to me. @jimtuttle So this PR should works as expected. Please verify and merge or let me know what else you need from me. |
JIRA Ticket: (https://webapps.es.vt.edu/jira/browse/LIBTD-2348) (:star:)
What does this Pull Request do? (:star:)
Repack Dspace zip file to tar to support Linux environment
How should this be tested?
Follow the readme.md, run the program, and verify it.
Interested parties
Tag (@jimtuttle @sindtd ) interested parties
(:star:) Required fields