-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular Status Bar item color control #9232
Open
ColinMelendez
wants to merge
16
commits into
VSCodeVim:master
Choose a base branch
from
ColinMelendez:feat-status-bar-item-color-control
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Granular Status Bar item color control #9232
ColinMelendez
wants to merge
16
commits into
VSCodeVim:master
from
ColinMelendez:feat-status-bar-item-color-control
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the ability to specify colors for the extension's status bar item text directly via theme settings with different colors for each mode. Example:
This is a nice feature for those who would like to have some easy visual indication of the current mode without having to color the entire status bar.
The approach provides customization options in a more idiomatic way for VS Code; allowing users to specify the color options as part of a theme or under the standard
"workbench.colorCustomizations"
setting.The original method of coloring the status bar is unchanged and unaffected by this PR - this is only an additional option that users can take advantage of by specifying color values for any of:
under
"workbench.colorCustomizations"
in their settings.All of the colors default to
"statusBar.foreground"
if unspecified.Which issue(s) this PR fixes
resolves #8741
Special notes for your reviewer:
I can add a section to the readme if desired.