"new_with_initialize" → "new" #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
requested review from
Hiroshiba,
qwerty2501 and
sevenc-nanashi
and removed request for
qwerty2501
|
@qwerty2501 すみません、今間違えてreview request飛ばしました… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Synthesizer::new_with_initializeとOpenJtalk::new_with_initialize、およびそれに対応するFFIをすべてリネームします。Synthesizerの方にはそもそも今は「initialize抜きのnew」が存在せず、OpenJtalkの方はOption<OpenJtalk>として運用すればよいです。（このあたりの話はどこかでした気がするけど、見あたらない…）
関連 Issue
#545
その他