Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_all_modelsを廃止する #587

Merged
merged 14 commits into from
Sep 8, 2023
Merged

load_all_modelsを廃止する #587

merged 14 commits into from
Sep 8, 2023

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Aug 26, 2023 •
edited
Loading

内容

load_all_modelsを廃止します。

関連 Issue

Resolves #582.

その他

@qryxip qryxip marked this pull request as draft August 26, 2023 09:28
@qryxip qryxip marked this pull request as ready for review August 26, 2023 10:41
qryxip
qryxip commented Aug 26, 2023
View reviewed changes
example/cpp/windows/simple_tts/simple_tts.vcxproj Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よくわからないが、CIのmsbuildを通すために設定を追加。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

通らない...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もう #588 のようなやつを用意していいのではと思いました。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、この文脈があることを知りませんでした！
#588 の方法を用意しちゃってもいい気がしました。

Copy link
Member Author

@qryxip qryxip Sep 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

通った...
https://github.com/VOICEVOX/voicevox_core/actions/runs/6099875868/job/16553382991?pr=587

This was referenced Aug 26, 2023
Open
Open
@qryxip qryxip requested a review from Hiroshiba September 6, 2023 17:14
@qryxip
Copy link
Member Author

qryxip commented Sep 6, 2023 •
edited
Loading

exampleはちょっと重んでいる状態ですが、CIは通りました。

Hiroshiba
Hiroshiba reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！

Hiroshiba
Hiroshiba approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

APIの役割分担が綺麗になったなと感じます･･･！

@Hiroshiba Hiroshiba merged commit 7624f7a into VOICEVOX:main Sep 8, 2023
@qryxip qryxip mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synthesisのload_all_modelsを廃止する
2 participants
@qryxip @Hiroshiba