Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete: 不要な依存を削除 #2054

Merged

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented May 3, 2024

内容

依存周りを良い感じにします。

  • cross-var:使わないように置き換え。テストビルド中。
  • vue:ERESOLVEが出てたので。
  • overrides.json5:無くてもよくなった
  • node-fetch:Node本体のfetchを使う
  • core-js:使われてなかった
  • babel.config.js:使われてなかった
  • @openapitools/openapi-generator-cli:警告が出ていたので更新。同じ結果になることは確認済。

関連 Issue

スクリーンショット・動画など

image

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner May 3, 2024 23:07
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team May 3, 2024 23:07
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

おー!!!
ありがとうございます!!!

@Hiroshiba
Copy link
Member

Hiroshiba commented May 4, 2024

マージします! devブランチがビルド通らなかったらまあcross-var周り再考ということで!
https://github.com/VOICEVOX/voicevox/actions/runs/8949132846

@Hiroshiba Hiroshiba merged commit 437a5f0 into VOICEVOX:main May 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants