Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] projectのschemaをdomainディレクトリ以下に移動 #1965

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Mar 30, 2024

内容

プロジェクトファイルのマイグレーションをファイル切り出ししてテスト可能にしたいです。
その第1弾として、マイグレーションで使っている部分の型宣言をdomainディレクトリ以下に移動します。
domain/projectディレクトリを新たに作ってそちらに移動しています。

関連 Issue

その他

git --no-pager  diff -w --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space upstream/main

したら変更は移動だけなことがわかるかと!

@Hiroshiba Hiroshiba requested a review from a team as a code owner March 30, 2024 11:15
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team March 30, 2024 11:15
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移動だけなら大丈夫だと思います。

@Hiroshiba
Copy link
Member Author

レビューありがとうございます!
他のプルリクエストともコンフリクトしなさそうなのでマージしたいと思います!

@Hiroshiba Hiroshiba merged commit 3a0b66e into VOICEVOX:main Apr 6, 2024
9 checks passed
@Hiroshiba Hiroshiba deleted the projectのschemaをdomainディレクトリ以下に移動 branch April 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants