ソング：歌詞の一括入力を追加 #1952
Merged
ソング：歌詞の一括入力を追加 #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
commented
Mar 23, 2024
Hiroshiba
reviewed
Mar 27, 2024
There was a problem hiding this comment.
概ね良さそうでした！！！ きれいな実装だと思います！
このPRの内容は実は以前課題があるよねと議論していたものだったので、そこは別で議論できればと思います 🙏
#1815 (comment)
（たぶんこの機能とUXのままマージできる･･･かも？）
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
|
レビューを反映しました。 |
This was referenced Mar 30, 2024
Closed
Hiroshiba
reviewed
Apr 5, 2024
Co-Authored-By: Hiroshiba <Hiroshiba@users.noreply.github.com>
|
レビューを反映しました。 |
Hiroshiba
approved these changes
Apr 5, 2024
Comment on lines
+402
to
+408
| const onNoteLyricInput = (text: string, note: Note) => { | ||
| splitAndUpdatePreview(text, note); | ||
| }; | ||
|
|
||
| const onNoteLyricBlur = () => { | ||
| commitPreviewLyrics(); | ||
| }; |
There was a problem hiding this comment.
ちなみにreactではemit側をon〜、引数指定側をhandle〜にしてたりします。
https://ja.react.dev/learn/responding-to-events#adding-event-handlers
ややこしくなったらそういうルールにしても良さそう。
|
反映しました。 |
Hiroshiba
requested changes
Apr 5, 2024
|
直ったと思います。 |
Hiroshiba
reviewed
Apr 5, 2024
|
これで良い感じになったはず？ |
Hiroshiba
approved these changes
Apr 17, 2024
| if (lastMatchEnd < text.length) { | ||
| moraAndNonMoras.push(text.substring(lastMatchEnd)); | ||
| } | ||
| if (moraAndNonMoras.length > maxLength) { |
There was a problem hiding this comment.
こっちもついでにコメント書いてあげようかなと
Suggested change
| if (moraAndNonMoras.length > maxLength) { | |
| // 指定した最大要素数より多い場合は配列を削る | |
| if (moraAndNonMoras.length > maxLength) { |
src/store/utility.ts
Outdated
Comment on lines
452
to
456
| export const convertKanaToHira = (text: string): string => { | ||
| return text.replace(/[\u30A1-\u30F4]/g, (s) => { | ||
| return String.fromCharCode(s.charCodeAt(0) - 0x60); | ||
| }); | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
タイトル通り。
関連 Issue
スクリーンショット・動画など
multi-mora.mp4
その他
モーラ分割とかの都合上長音対応も入ってます。