Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ログの改善 #1910

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Conversation

sevenc-nanashi
Copy link
Member

内容

[scope] message のログを作る機構を統一します。
また、このフォーマットに沿っていないところをこのフォーマットを使うようにします。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner March 6, 2024 11:20
@sevenc-nanashi sevenc-nanashi requested review from y-chan and removed request for a team March 6, 2024 11:20
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOG_WARNとか消しちゃうのいいですね!
2経路あるの気になってたので、こっち消しちゃう形で賛成です。

src/helpers/log.ts Outdated Show resolved Hide resolved
src/helpers/log.ts Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

すっきりして良いですね!!

src/store/engine.ts Outdated Show resolved Hide resolved
src/store/singing.ts Outdated Show resolved Hide resolved
src/domain/frontend/log.ts Show resolved Hide resolved
@sevenc-nanashi
Copy link
Member Author

レビューを反映しました。

@@ -1,4 +1,5 @@
/** ログ出力用の関数を生成する。ブラウザ専用。 */
// TODO: DIできるようにする
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目的語があるとコメントが不要になったかどうかの判断しやすいかも

Suggested change
// TODO: DIできるようにする
// TODO: window.backendをDIできるようにする

error: e,
message: `Failed to restart engine: ${engineId}`,
});
const { error } = createLogger("RESTART_ENGINES");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

store内のローカルのcreateLogger残ってそうです
他にも後何個かありそう

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit 507f98c into VOICEVOX:main Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants