Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] ダイアログ系のコンポーネントを移動 #1780

Conversation

Hiroshiba
Copy link
Member

内容

(project-sを削除すると以前のプルリクエストが強制close&PR先変更不可になってしまったので再オープンしました 🙇 )

ダイアログ系のコンポーネントをsrc/components/Dialog/ディレクトリの下に移動します

移動するとこんな感じ

関連 Issue

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner January 28, 2024 22:32
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team January 28, 2024 22:32
@Hiroshiba Hiroshiba changed the title HelpDialog [refactor] ダイアログ系のコンポーネントを移動 Jan 28, 2024
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 5ad43b2 into VOICEVOX:main Jan 29, 2024
8 checks passed
@Hiroshiba Hiroshiba deleted the ダイアログコンポーネントを分けていく branch January 29, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants