Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 無視テキスト関連のバグ修正 #1428

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

thiramisu
Copy link
Contributor

@thiramisu thiramisu commented Jul 27, 2023

内容

txtファイル書き出しがONの時に無視するテキスト(読みとメモ)が一部無視されなかったのと無視されすぎたのを修正します。

  • 一つだけ書き出し時に無視されない。
  • Shift_JISで音声を繋げて書き出し時に無視されない。
  • 音声を繋げて書き出し時に、以下が構文と認識されて無視されてしまう。
{字幕もどき|(改行)
読みもどき}

また、utilityから関数一つで呼べるようにします。

関連 Issue

@thiramisu thiramisu requested a review from a team as a code owner July 27, 2023 10:33
@thiramisu thiramisu requested review from y-chan and removed request for a team July 27, 2023 10:33
@Hiroshiba Hiroshiba requested review from Hiroshiba and removed request for y-chan July 27, 2023 20:14
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

漏れがあったのは全く気づいていませんでした、ありがとうございます 🙇

@weweweok さんの取り組んでくださったところの追加修正にあたるので、共有も兼ねてリプライさせていただきます!!

@Hiroshiba Hiroshiba merged commit fcdf82d into VOICEVOX:main Jul 27, 2023
7 checks passed
@thiramisu thiramisu deleted the fix-skipped-text branch July 28, 2023 00:03
@weweweok
Copy link
Contributor

修正参考になります。ありがとうございました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants