Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: デフォルトプリセットが正常に生成されない問題を修正 #1305

Merged
merged 1 commit into from
May 4, 2023
Merged

FIX: デフォルトプリセットが正常に生成されない問題を修正 #1305

merged 1 commit into from
May 4, 2023

Conversation

sabonerune
Copy link
Contributor

内容

エンジン起動時に一括作成されるはずのデフォルトプリセットが一番最初のキャラクターしか作成されていなかったのでそれを修正します。

関連 Issue

@sabonerune sabonerune requested a review from a team as a code owner May 3, 2023 08:31
@sabonerune sabonerune requested review from Hiroshiba and removed request for a team May 3, 2023 08:31
Hiroshiba
Hiroshiba approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

まったく気づいてませんでした、ありがとうございます！！！

@Hiroshiba
Copy link
Member

（もしかしたら似た修正されてるかもなのでご共有です･･･！ @k-chop ）

@Hiroshiba Hiroshiba merged commit b49c3b5 into VOICEVOX:main May 4, 2023
@sabonerune sabonerune deleted the fix/CREATE_ALL_DEFAULT_PRESET branch May 4, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabonerune @Hiroshiba