upload release/artifact用Actionを解体して個別に実行 #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
あ、if判定がrelease/assetで逆ですね。。 |
|
これで良いはず･･･！ |
Hiroshiba
commented
Mar 23, 2023
Comment on lines
+32
to
+33
| |- # releaseタグ名か、workflow_dispatchでのバージョン名か、999.999.999-developが入る | ||
| ${{ github.event.release.tag_name || github.event.inputs.version || '999.999.999-develop' }} |
There was a problem hiding this comment.
一般的に最新版判定はsemverの比較を使うんですが、999.999.999-developみたくprereleaseタグになっているとたしかすべての比較に引っかからないという特性があります。
0.14<999.999.999-developがfalseになるはず。
なのでこうやってタグを付けておくと安心かなと！
|
@y-chan こちらマージしないとまた999.999.999ができちゃうので、見ていただけると 🙇♂️ |
|
レビューありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
Composite Actionはifが使えないらしく、uploadフラグ判定が機能しませんでした。
upload release/artifactを解体して各々で処理してみました。
関連 Issue
close #1260
スクリーンショット・動画など
その他
他の作戦としては、Composite Actionのままgithub CLIを使って自作する手がありますが、流石に大変かなと思ったのでこうしました。
かなり冗長な記述になってしまうので悲しい･･･。