Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

書き出し結果画面を書き直し #1242

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

タイトル通り。

関連 Issue

(なし)

スクリーンショット・動画など

image

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner March 4, 2023 14:02
@sevenc-nanashi sevenc-nanashi requested review from y-chan and removed request for a team March 4, 2023 14:02
package.json Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMですが1箇所だけ気になったので聞いてみました!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba
Copy link
Member

pathライブラリに関してはこちらにissueを作ってみました。(良い方法、無いのでは・・・?)

@Hiroshiba
Copy link
Member

問題ないと思うのでマージします! PRありがとうございます!!

@Hiroshiba Hiroshiba merged commit a23a7ac into VOICEVOX:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants