Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

未対応エンジン追加時にリストが消える件(#1168) #1179

Merged
merged 6 commits into from
Feb 11, 2023
Merged

未対応エンジン追加時にリストが消える件(#1168) #1179

merged 6 commits into from
Feb 11, 2023

Commits on Feb 5, 2023

  1. 未対応エンジン追加時にリストが消える件(VOICEVOX#1168) 

    ・追加されたエンジンが未対応である場合には追加を阻止
・追加されてしまっている場合には、エラーで処理中断しないように
    @nmori
    nmori committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    0972e5e View commit details
    Browse the repository at this point in the history

  2. lintチェックエラー部分の修正

    @nmori
    nmori committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    cb5552c View commit details
    Browse the repository at this point in the history

  3. コードレビューの反映 (ref VOICEVOX#1179) 

    ・MinimumEngineManifestの更新
    @nmori
    nmori committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    00b7673 View commit details
    Browse the repository at this point in the history

  4. コードレビュー分の反映②　ref VOICEVOX#1179 

    ・engineManifests[selectedId]自体が undefined であるケースに対応
    @nmori
    nmori committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    4b21b85 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Merge branch 'main' of https://github.com/voicevox/voicevox

    @nmori
    nmori committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ad8c1de View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. * コンフリクトの修正

    @nmori
    nmori committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    6e91471 View commit details
    Browse the repository at this point in the history