Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hash builtins for K2 #1212

Merged
merged 14 commits into from
Jan 20, 2025
Merged

Implement hash builtins for K2 #1212

merged 14 commits into from
Jan 20, 2025

Conversation

mkornaukhov03
Copy link
Contributor

@mkornaukhov03 mkornaukhov03 commented Jan 16, 2025 •
edited
Loading

This PR add support for the following builtins in K2 mode:

  • hash()
  • hash_hmac()
  • hash_algos()
  • hash_hmac_algos()
  • hash_equals()
  • sha1()
  • crc32()

Also one hash test was divided into several.

@mkornaukhov03 mkornaukhov03 self-assigned this Jan 16, 2025
@mkornaukhov03 mkornaukhov03 added the k2 k2 related label Jan 17, 2025
apolyakov
apolyakov requested changes Jan 17, 2025
View reviewed changes
runtime-common/stdlib/hash/hash-functions.h Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.h Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.h Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.cpp Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.cpp Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.cpp Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto_schema.tl Outdated Show resolved Hide resolved
runtime-light/tl/tl-functions.h Show resolved Hide resolved
apolyakov
apolyakov requested changes Jan 17, 2025
View reviewed changes
runtime-common/stdlib/crypto/crypto-functions.cpp Show resolved Hide resolved
runtime-common/stdlib/string/string-functions.h Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.cpp Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.cpp Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.cpp Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.cpp Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.h Outdated Show resolved Hide resolved
runtime-light/stdlib/crypto/crypto-functions.h Outdated Show resolved Hide resolved
@mkornaukhov03 mkornaukhov03 force-pushed the mkornaukhov03/hash-builtins branch from 0b88fbb to e435684 Compare January 17, 2025 14:19
apolyakov
apolyakov approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@apolyakov apolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

astrophysik
astrophysik approved these changes Jan 20, 2025
View reviewed changes
common/crc32_generic.h Show resolved Hide resolved
@mkornaukhov03 mkornaukhov03 merged commit 378807c into master Jan 20, 2025
5 checks passed
@mkornaukhov03 mkornaukhov03 deleted the mkornaukhov03/hash-builtins branch January 20, 2025 11:21
@Danil42Russia Danil42Russia added this to the next milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrophysik astrophysik astrophysik approved these changes

@apolyakov apolyakov apolyakov approved these changes

Assignees

@mkornaukhov03 mkornaukhov03

Labels
k2 k2 related
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
4 participants
@mkornaukhov03 @apolyakov @astrophysik @Danil42Russia