Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: rm cjs #7574

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Sep 12, 2024

Описание

CJS устарел

Изменения

  • Была выпилена cjs сборка
  • cjs остался для styleguide. Должно уйти после обновления документации
  • Экспорты были ограничены. Теперь никто не сможет импортировать кишки vkui

Release notes

BREAKING CHANGE

  • Была удалена cjs сборка
  • Импортировать внутренности VKUI теперь запрещено на уровне свойства exports в package.json

Copy link

codesandbox-ci bot commented Sep 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

👀 Docs deployed

Commit 6837def

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (381c1f0) to head (6837def).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7574   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         384      384           
  Lines       11345    11345           
  Branches     3720     3720           
=======================================
  Hits        10802    10802           
  Misses        543      543           
Flag Coverage Δ
unittests 95.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud force-pushed the SevereCloud/BREAKING-CHANGE/rm-cjs branch from 1e08407 to 0d601fc Compare September 16, 2024 09:12
@SevereCloud SevereCloud force-pushed the SevereCloud/BREAKING-CHANGE/rm-cjs branch from 0d601fc to 6837def Compare September 17, 2024 11:05
Copy link
Contributor

e2e tests

Playwright Report

inomdzhon pushed a commit that referenced this pull request Sep 17, 2024
Удаляем prettier.config.mjs, прописываем конфиг в package.json

- распил #7574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE]: удалить cjs сборку
1 participant