Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Flex): add margin auto offset #7426

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

BlackySoul
Copy link
Contributor

  • e2e-тесты

Описание

Из-за того, что по умолчанию --vkui_internal--row_gap и --vkui_internal--column_gap устанавливались в 0, то при их участии в расчете через calc свойство margin рассчитывалось неверно (отсутствовали отступы сверху-слева)

Изменения

Инициализируем значения как 0px

@BlackySoul BlackySoul added this to the v6.5.2 milestone Aug 22, 2024
@BlackySoul BlackySoul self-assigned this Aug 22, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner August 22, 2024 08:36
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 22, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 378.36 KB (0%)
JS (gzip) 114.79 KB (0%)
JS (brotli) 94.28 KB (0%)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 306.22 KB (+0.01% 🔺)
CSS (gzip) 39.28 KB (+0.01% 🔺)
CSS (brotli) 31.54 KB (+0.18% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit c198ef0

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (bb02ab8) to head (c198ef0).
Report is 29 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7426   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         375      375           
  Lines       11133    11133           
  Branches     3650     3650           
=======================================
  Hits        10519    10519           
  Misses        614      614           
Flag Coverage Δ
unittests 94.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit 0792816 into master Aug 26, 2024
28 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_flex_margin_auto branch August 26, 2024 09:43
vkcom-publisher pushed a commit that referenced this pull request Aug 26, 2024
* fix(Flex): margin auto offset

* CHORE: Update screenshots

---------

Co-authored-by: GitHub Action <actions@github.com>
@vkcom-publisher
Copy link
Contributor

v6.5.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:flex patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants