Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search): clear button not disabled #7422

Merged

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Aug 22, 2024

Описание

Кнопка очистки была доступна не смотря на то, что поиск был задисайблен

image

Изменения

Отключаем кнопку очистки при передаче disabled в компонент поиска

Кнопка очистки была доступна не смотря на то, что поиск был задисайблен

Отключаем кнопку очистки при передаче `disabled` в компонент поиска
@SevereCloud SevereCloud requested a review from a team as a code owner August 22, 2024 07:13
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 22, 2024
@SevereCloud SevereCloud added this to the v6.5.2 milestone Aug 22, 2024
@SevereCloud SevereCloud self-assigned this Aug 22, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 378.26 KB (+0.01% 🔺)
JS (gzip) 114.72 KB (+0.01% 🔺)
JS (brotli) 94.15 KB (+0.12% 🔺)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 306.22 KB (0%)
CSS (gzip) 39.28 KB (0%)
CSS (brotli) 31.49 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 0d52c4f

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (ec558fb) to head (0d52c4f).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7422   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         375      375           
  Lines       11122    11122           
  Branches     3645     3645           
=======================================
  Hits        10511    10511           
  Misses        611      611           
Flag Coverage Δ
unittests 94.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit abfc26b into master Aug 23, 2024
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Search/clear-button-not-disabled branch August 23, 2024 08:58
vkcom-publisher pushed a commit that referenced this pull request Aug 23, 2024
Кнопка очистки была доступна не смотря на то, что поиск был задисайблен

Отключаем кнопку очистки при передаче `disabled` в компонент поиска
@vkcom-publisher
Copy link
Contributor

v6.5.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:search patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants