Add attempt count to queue model #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxcapades
reviewed
Nov 6, 2023
src/main/kotlin/org/veupathdb/lib/rabbit/jobs/model/ErrorNotification.kt
Outdated
Show resolved
Hide resolved
Foxcapades
reviewed
Nov 6, 2023
src/main/kotlin/org/veupathdb/lib/rabbit/jobs/model/ErrorNotification.kt
Show resolved
Hide resolved
|
Two possible code concerns, and a general concern as to whether this belongs as part of the raw dispatch object or as part of the JSON body (where relevant). The retry count is fine here either way as the async platform is currently the only consumer of this library, but it feels to me like this is a detail specific to the consumers of this project not this project itself? |
Foxcapades
reviewed
Nov 7, 2023
src/main/kotlin/org/veupathdb/lib/rabbit/jobs/model/JobDispatch.kt
Outdated
Show resolved
Hide resolved
Foxcapades
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add attempt count to queue model to enable retries in async platform.