Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v490.9-dev2 - removal of size2 #265

Merged
merged 19 commits into from
May 18, 2024
Merged

v490.9-dev2 - removal of size2 #265

merged 19 commits into from
May 18, 2024

Conversation

GernotMaier
Copy link
Member

@GernotMaier GernotMaier commented Apr 18, 2024

Inconsistent usage of size2 with different meanings:

  • size calculated from longer integration windows (to reduce the systematic for low-gain traces)
  • size from squared image calculation (which is not really implemented)
  • save of size in calcLL calculation

Also noticed that calcLL is called twice due to this.

Remove size2 and consistently use size in evndisp and mscw_energy.

Fix issues in github action workflows.

@GernotMaier GernotMaier self-assigned this Apr 18, 2024
@GernotMaier GernotMaier marked this pull request as ready for review May 17, 2024 17:03
@GernotMaier GernotMaier merged commit 37d0bcf into main May 18, 2024
4 of 5 checks passed
@GernotMaier GernotMaier deleted the size2 branch May 18, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant