Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v490 - alpha.0.8 #208

Merged
merged 11 commits into from
Nov 7, 2022
Merged

v490 - alpha.0.8 #208

merged 11 commits into from
Nov 7, 2022

Conversation

GernotMaier
Copy link
Member

@GernotMaier GernotMaier commented Oct 19, 2022

Changes related to v490-alpha.7

  • improved installation hints
  • critical bug fix in filling lookup tables, using the correct direction values

Combine lookup tables

More flexibility to find correct NSB bins when combing lookup tables; add command line parameters noise tolerance in combineEffectiveAreas.

Propagation of cluster cleaning from v5

Propagated cluster cleaning from v5 to v490.

  • removes islands with N pixels or with size smaller than a certain value
  • settings see EVNDISP.reconstruction.runparameter.CC.v4x

Addition of AP cleaning

Addition of removal of islands consisting of a single image and a single border pixel, triggered by Jamie's study on increased afterpulsing contributions.

  • switch this on by adding one parameter 1 to * -1 IMAGECLEANINGTHRESHOLDS 5. 2.5 1
  • settings see EVNDISP.reconstruction.runparameter.AP.v4x

Improvement of optimized next-neighbour cleaning

Improved handling of short runs when there are not enough entries in the pedestal histograms to determine correct cleaning cuts. In this case, a single average histogram is filled to calculate the cleaning thresholds.

@GernotMaier GernotMaier self-assigned this Oct 24, 2022
@GernotMaier GernotMaier added this to the v490 release milestone Oct 24, 2022
@GernotMaier GernotMaier marked this pull request as ready for review November 7, 2022 14:38
@GernotMaier GernotMaier merged commit f95010b into main Nov 7, 2022
@GernotMaier GernotMaier deleted the v490-dev-v0.8 branch November 7, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant