-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VLikelihoodFitter in v487 5% disagreement #164
Comments
Standard Fit Results (v486):
Likelihood Fit Results (v486):
|
OK. That will be a nightmare to debug. IRFs should be exactly the same between v487 and v486 (with the exception of the axis bug in e_sys_rel). There is no new IRF calculation for v487, it is only filled differently at the combine effective area stage. This requires also a different reading of the values in VEffectiveArea. |
Just checked the gammapy analysis between v486 and v487, relying on the same IRFs as the binned likelihood fitter in anasum: results are identical (<0.05% difference). This means it is an issue with reading the values. |
@steob92 please test again with the last commit c74a45b It was indeed an issue with reading the values: with two effective areas trees (one for values as function of reconstructed energies and the second one as function of true energies), one needs to take care to read out the correct values. effective area tree with 20x less entries and the relation between the tree entry index is:
VEffectiveAreaCalculator is incredibly complicated. |
I'll take a look. Is the previous effective area file you game me still valid? |
Yes, that file should work. I was simply getting the wrong entry from the tree for the IRFs as function of true energy. |
The results look good. There is a very small (~2%) discrepancy in the lowest energy bins. This isn't new, but its a little more evident than the v486 analysis. I believe it is due to how threshold are handled in standard analysis and likelihood analysis. The response matrix essentially includes sub-threshold events when integrating to get the predicted above threshold events. I don't know if this is worth pursuing more? Standard Fit results (v487):
Likelihood Fit result:
|
But this is a difference between standard and likelihood analysis, and not a difference between the two different ways of writing IRFs? |
Correct. This is unrelated to how the IRFs are generated. |
Good - I am closing the issue, as I think we have solved the initial problem. |
Hi Gernot, Was this bug fix implemented in v487b? I've been looking into the previously mention 2% discrepancy around energy threshold and it appears that I'm seeing a consistent 5% discrepancy above ~700 GeV. We previously saw this in a development branch for v487 (this issue). Before I go into further debugging, was this fix implemented into v487b? All the best, |
Just looked again through the code and the fix is applied (was commit c74a45b). It is already fixed in v487b (see EventDisplay_v4/src/VEffectiveAreaCalculator.cpp Line 1369 in 87bd52c
Not sure what to do now - are you absolutely sure that it re-appeared or was it never gone? |
I'm not entirely sure I'm not just doing something stupid... I have some local changes that I was testing. I'm also using IRFs downloaded by someone else. Let me try and consolidate with a base v487b install and IRFs I can confirm are the correct versions. I'll take a look over the weekend. |
Let's reopen this issue and address it. Looks like Sonal is seeing something similar when looking into the gammapy results. |
Rerunning knowing I'm using the correct IRFs and using a fresh v487c install I still see the same results for the previously posted runlist, which was:
Using the Crab_V6_v400_release runlist:
I get the attached results. The comparison is a little better, but there still is a ~2.5% discrepancy. I've also attached the MC effective areas for run 64081 ( |
@steob92 - I think I found the issue: First, I can replicate the problem (there is an option when combining effective area trees ( I bit of digging found hopefully the issue and I've applied a bug fix in the branch Could you check again and test the problem with v487d-dev-v0.1? |
Unfortunatly this doesn't appear to solve the issue. The discrepancy increases to ~5% using the Crab_V6_v400_release runlist:
|
I am closing this, as we do not expect to make progress on this topic |
In v487 VLikelihoodFitter is showing a consistent ~5% disagreement with the standard chi^2 fitter (VEnergySpectrum).
Standard Fit:
Likelihood Fit
The text was updated successfully, but these errors were encountered: