Fixing possible NPE in OverviewActivity.launchSearch #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, 👍 Only thing I ask is that your patches please use spaces instead of tabs for indents. Btw, gl on your PhD and congrats on your future job! |
|
Great, thanks! I will remove the tabs from the other pull request as well. |
UweTrottmann
added a commit
that referenced
this pull request
Mar 21, 2015
Fixing possible NPE in OverviewActivity.launchSearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBUtils.getShow can return null and its return value is checked for null in other places where the method is called. This pull request fixes a possible NPE on an call to DBUtils.getShow where the return value is not checked for null before dereferencing.
Just to be clear, I identified this bug using a static analysis tool that I have been developing and have not attempted to reproduce this issue while running the app.