Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sensors from liquidctl #202

Conversation

jonasmalacofilho
Copy link

liquidctl is a cross-platform tool to monitor and control many all-in-one liquid coolers, fan controllers, PSUs and some other devices. This PR adds support for showing sensor data from liquidctl in Freon.

Since many types of sensors are supported, merge the data from liquidctl and sensors and use the generic temperature, rpm and voltage sections. Also add a new switch to the preferences to enable/disable this feature.

Screenshot from 2021-04-29 07-04-22

This PR uses a new --json flag from liquidctl, and this currently requires a recent git snapshot. Because of this, keep it as a draft PR for now, but those comfortable with git can already start testing/using it.

Any feedback would be very appreciated.

Requires liquidctl v1.7.0 or later, or a current git snapshot.
@UshakovVasilii UshakovVasilii marked this pull request as ready for review April 29, 2021 12:01
@UshakovVasilii UshakovVasilii marked this pull request as draft April 29, 2021 12:03
@jonasmalacofilho jonasmalacofilho marked this pull request as ready for review July 20, 2021 08:48
@jonasmalacofilho
Copy link
Author

liquidctl 1.7.0 has been released with the --json flag that's necessary for this extension, so I'm marking the PR as ready for review.

@UshakovVasilii UshakovVasilii merged commit 1730654 into UshakovVasilii:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants