Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to gnome-extensions prefs on Gnome Shell 3.36 #168

Merged
merged 2 commits into from
May 3, 2020
Merged

Switch to gnome-extensions prefs on Gnome Shell 3.36 #168

merged 2 commits into from
May 3, 2020

Conversation

askmrsinh
Copy link

On Gnome 3.36 gnome-shell-extension-prefs might not be installed by default.

Copy link

@jonasmalacofilho jonasmalacofilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue I was having with "Sensor Settings" where nothing would happen/open. Thanks!

But it seems that the preferred way for an extension to open its preferences is now ExtensionUtils.openPrefs().[1][2]

There was also a comment about gnome-extensions not always being available either, but I couldn't verify that (checked Arch and Ubuntu).

Also, the breaking changed apparently happened in 3.36.1, (EDIT) but ExtensionUtils.openPrefs() is only available from 3.36.2 forwards.

[1] Tudmotu/gnome-shell-extension-clipboard-indicator#203
[2] https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1163

@jonasmalacofilho
Copy link

jonasmalacofilho commented May 2, 2020

Oh, in 3.36.1 ExtensionUtils.openPrefs() isn't yet available but gnome-shell-extension-prefs stops accepting an UUID.

To support 3.36.1 and, probably, 3.36.0 too (instead of only 3.36.2), I think we should stick with the solution proposed here and only change to the new D-Bus based method for GNOME 3.37.

@UshakovVasilii UshakovVasilii merged commit 758a5c5 into UshakovVasilii:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants