Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latitude & Longitude scalars #748

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Latitude & Longitude scalars #748

merged 2 commits into from
Mar 8, 2021

Conversation

carlocorradini
Copy link
Contributor

@carlocorradini carlocorradini commented Mar 5, 2021

Description

Added Latitude & Longitude scalars.

Latitude: latitude is a geographic coordinate that specifies the north–south position of a point on the Earth's surface.

Longitude: is a geographic coordinate that specifies the east–west position of a point on the Earth's surface, or the surface of a celestial body.

The input value can be either in decimal (53.471) or sexagesimal (53° 21' 16") format.

The output value is always in decimal format (53.471).

The maximum decimal degrees precision is 8. See Decimal Degrees Precision for more information.

Scalars inspired by Geolib.

Related #747

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Multiple latitudes & longitudes in DMS & DD format.

Tested invalid value & type & range.

Test Environment:

  • OS: Microsoft Windows 10 Pro 10.0.19042 Build 19042
  • GraphQL Scalars Version: 1.8
  • NodeJS: 12.13.1

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
PLEASE, I WANT A REVIEW ABOUT THESE NEW SCALARS TO ENSURE THAT I HAVEN'T MADE ANY ERRORS... THANKS!
@ardatan
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@ardatan
Copy link
Collaborator

ardatan commented Mar 8, 2021

That's awesome! Thanks @carlocorradini !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants