Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Suggestions #1

Closed
wants to merge 5 commits into from
Closed

Readme Suggestions #1

wants to merge 5 commits into from

Conversation

cfnelson
Copy link
Contributor

@cfnelson cfnelson commented Jun 16, 2017

Note: Made a branch only to think/show thoughts on changing the structure of the Readme. Would love to get others adding/remixing this.

Questions:

  • Can Date timestamp be setup to only allow/conform to a RFC standard? Noticed the error thrown if an invalid format in the source code?
  • Can we reference an RFC or JS standard for the Int's / Floats? Or should we be more descriptive of what they support. I think it was great what you did with linking to the RFC standards. 🎉 Makes me feel like I can trust the package.

Additional things I think would be great to add to ReadMe:

  • Badges for CI, Tests, etc.
  • A Cool simple Logo from Karl or Oliver
  • Screenshot or gif of what it does?
  • A demo and is it possible to have a live demo/example link (can we use MDG's https://launchpad.graphql.com)?

Bonus:

  • Spread syntax for obejcts is from es6 at stage 3 :)

@ghost
Copy link

ghost commented Jan 16, 2018

Reviewed suggestions. Incorporated some. Added some to future checklist. Thanks. Closing.

@ghost ghost closed this Jan 16, 2018
@ghost ghost deleted the update-readme branch January 16, 2018 19:19
ardatan pushed a commit that referenced this pull request Mar 12, 2020
* feat(objectid-scalar): mongodb object id scalar type

Adds mongodb object id scalar type.

* style(editorconfig): editorconfig to help format code

Adds [editorconfig](https://editorconfig.org/) to helps maintain coding style for developers.

* style(commitlint): git commit message linting

Enforces commit message standards on subsequent contributors to this project.

* docs(mongodb-objectid): documents the usage of the mongodb objectid

Documents the usage of the mongodb objectid scalar type.

* feat(mongodb-objectid): mongodb objectid scalar type

Adds mongodb objectid scalar type

* feat(mongodb-objectid): mongodb objectid scalar type

Adds a mongodb objectid scalar type definition to the already existing list of definitions.

* conflict resolution (#1)

package.json rebased

* feat(objectid-scalar): mongodb object id scalar type

Adds mongodb object id scalar type.

* docs(mongodb-objectid): documents the usage of the mongodb objectid

Documents the usage of the mongodb objectid scalar type.

* git rebase (#2)

conflict resolution -package.json

* feat(objectid-scalar): mongodb object id scalar type

Adds mongodb object id scalar type.

* style(editorconfig): editorconfig to help format code

Adds [editorconfig](https://editorconfig.org/) to helps maintain coding style for developers.

* style(commitlint): git commit message linting

Enforces commit message standards on subsequent contributors to this project.

* docs(mongodb-objectid): documents the usage of the mongodb objectid

Documents the usage of the mongodb objectid scalar type.

* feat(mongodb-objectid): mongodb objectid scalar type

Adds a mongodb objectid scalar type definition to the already existing list of definitions.

* build: remove package-lock.json
vespertilian pushed a commit to vespertilian/graphql-scalars that referenced this pull request Oct 2, 2020
* feat(objectid-scalar): mongodb object id scalar type

Adds mongodb object id scalar type.

* style(editorconfig): editorconfig to help format code

Adds [editorconfig](https://editorconfig.org/) to helps maintain coding style for developers.

* style(commitlint): git commit message linting

Enforces commit message standards on subsequent contributors to this project.

* docs(mongodb-objectid): documents the usage of the mongodb objectid

Documents the usage of the mongodb objectid scalar type.

* feat(mongodb-objectid): mongodb objectid scalar type

Adds mongodb objectid scalar type

* feat(mongodb-objectid): mongodb objectid scalar type

Adds a mongodb objectid scalar type definition to the already existing list of definitions.

* conflict resolution (Urigo#1)

package.json rebased

* feat(objectid-scalar): mongodb object id scalar type

Adds mongodb object id scalar type.

* docs(mongodb-objectid): documents the usage of the mongodb objectid

Documents the usage of the mongodb objectid scalar type.

* git rebase (Urigo#2)

conflict resolution -package.json

* feat(objectid-scalar): mongodb object id scalar type

Adds mongodb object id scalar type.

* style(editorconfig): editorconfig to help format code

Adds [editorconfig](https://editorconfig.org/) to helps maintain coding style for developers.

* style(commitlint): git commit message linting

Enforces commit message standards on subsequent contributors to this project.

* docs(mongodb-objectid): documents the usage of the mongodb objectid

Documents the usage of the mongodb objectid scalar type.

* feat(mongodb-objectid): mongodb objectid scalar type

Adds a mongodb objectid scalar type definition to the already existing list of definitions.

* build: remove package-lock.json
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant