Terraform ECR repositories #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrewer-forge
suggested changes
Jul 12, 2018
| "Effect": "Allow", | ||
| "Principal": { | ||
| "AWS": [ | ||
| "arn:aws:iam::${alm_account_id}:user/jmorris", |
There was a problem hiding this comment.
Do you mean why are you not on here?
Because we forgot to add you when you joined the team and I copy/pasted the manually created policy for the other repositories into here.
If you’re not Ben, then you’re here so you have rights to pull images from the repository for local development.
There was a problem hiding this comment.
Both added along with the other new team members.
This works *most* of the time, but there's a bug in terraform that causes the ECR policy to fail sometimes. hashicorp/terraform-provider-aws#545 co-authored-by: Paul Linville <plinville@pillartechnology.com>
rubberduck203
force-pushed
the
ecr_repositories
branch
from
e1b6d61
to
f9c3037
Compare
bbrewer-forge
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works most of the time, but there's a bug in terraform that causes
the ECR policy to fail sometimes.
hashicorp/terraform-provider-aws#545
co-authored-by: Paul Linville plinville@pillartechnology.com