Change import_objects to generate a BASH script instead of pmrep comm…

…and file (#37) * Changed import_objects.groovy to generate bash script instead of pmrep command file. * Fixed code left behind to look at lastLine of output file
UrbanCode · Jan 10, 2018 · f1eaf81 · f1eaf81
1 parent 930a903
commit f1eaf81
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 37 deletions.
diff --git a/plugin/info.xml b/plugin/info.xml
@@ -239,5 +239,8 @@ Added Folder Migration and Validate Folder Migration steps.
     <release-note plugin-version="28">
 Added a new step - "Deploy Multiple Deployment Groups"
     </release-note>
+    <release-note plugin-version="29">
+Modified import_objects.groovy to run pmrep commands one at a time in a bash script, instead of passing pmrep a command file.
+    </release-note>
   </release-notes>
 </pluginInfo>
diff --git a/plugin/plugin.xml b/plugin/plugin.xml
@@ -11,7 +11,7 @@
 -->
 <plugin xmlns="http://www.urbancode.com/PluginXMLSchema_v1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
   <header>
-    <identifier version="28" id="com.urbancode.air.plugin.Informatica" name="Informatica"/>
+    <identifier version="29" id="com.urbancode.air.plugin.Informatica" name="Informatica"/>
     <description>
     The Informatica plugin is an automation based plugin. It is executed as part of the deployment to migrate Informatica configuration and run scripts against the Informatica server and for creating and deploying deploying groups.
     </description>

diff --git a/plugin/upgrade.xml b/plugin/upgrade.xml
@@ -252,4 +252,6 @@
       <migrate-command name="Deploy Multiple Deployment Groups">
       </migrate-command>
   </migrate>
+  <migrate to-version="29">
+  </migrate>
 </plugin-upgrade>
diff --git a/src/main/scripts/import_objects.groovy b/src/main/scripts/import_objects.groovy
@@ -45,8 +45,7 @@ final def conflictResolutionDefault = stepProps['conflictResolutionDefault'];
 final def retainGenSeq = Boolean.valueOf(stepProps['retainGenSeq']);
 final def checkinAfterImport = Boolean.valueOf(stepProps['checkinAfterImport']);
 
-final def inputFile = 'informatica_script.' + unique + '.in'
-final def outputFile = 'informatica_script.' + unique + '.out'
+final def inputFile = 'informatica_script.' + unique + '.sh'
 final def controlFile = 'informatica_script.' + unique + '.ctl'
 
 final def conflictRuleSet = [
@@ -112,9 +111,21 @@ else {
         fileSet << [(newXmlFile) : "${oldFileName}.xml"]
     }
 
-    // generate Informatica script
+    // generate Bash script with pmrep Informatica commands
     def script = new File(workDir, inputFile)
-	script.deleteOnExit()
+    script.deleteOnExit()
+
+    script << "#!/bin/bash $LS";
+
+    script.setExecutable(true);
+
+    if (infaHome != null && infaHome != "") {
+            script << infaHome + File.separator + "server" + File.separator + "bin" + File.separator + "pmrep ";
+    }
+    else {
+            script << 'pmrep ';
+    }
+
     script << "connect -r $repo -n $username -x $password "
 
     if (securityDomain){
@@ -129,11 +140,16 @@ else {
     }
 
     fileSet.keySet().each {
+        if (infaHome != null && infaHome != "") {
+            script << infaHome + File.separator + "server" + File.separator + "bin" + File.separator + "pmrep ";
+        }
+        else {
+            script << 'pmrep ';
+        }
         def filePrefix = it.name.substring(0, it.name.indexOf(".xml"))
         script << "ObjectImport -i \"$it\" -c \"${filePrefix}.ctl\" $LS"
     }
 
-    script << "exit"
     println('script content:')
     script.eachLine { line -> println(line) }
     println('')
@@ -251,19 +267,7 @@ else {
 
     //run the Informatica command
     def command = []
-    if (infaHome != null && infaHome != "") {
-        command.add(infaHome + File.separator + "server" + File.separator + "bin" + File.separator + "pmrep");
-    }
-    else {
-        command.add('pmrep')
-    }
-    command.add('run')
-    command.add('-o')
-    command.add(outputFile)
-    command.add('-f')
     command.add(inputFile)
-    command.add('-e')
-    command.add('-s')
 
     println('command:')
     println(command.join(' '))
@@ -308,25 +312,7 @@ else {
         process.getOutputStream().close() // close stdin
         process.waitFor()
 
-        def output = new File(workDir, outputFile)
-        Scanner sc = new Scanner(output)
-        println('pmrep output:')
-        def lastLine = ""
-        while (sc.hasNextLine()) {
-            lastLine = sc.nextLine()
-            println(lastLine)
-        }
-        println('')
-        sc.close()
-
-        output.delete()
-
-        if (!lastLine || !lastLine.trim().equalsIgnoreCase("exit")) {
-            exitCode = 1
-        }
-        else {
-            exitCode = process.exitValue()
-        }
+        exitCode = process.exitValue();
     }
     catch (Exception ex) {
         println "[Error] Please review the output log and stack trace for information on the error."