Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker image #88

Merged

Conversation

easybe
Copy link
Collaborator

@easybe easybe commented Aug 27, 2024

On every release, a new image, containing the latest PyPI package, is built and pushed to Docker Hub:
https://hub.docker.com/r/upstreamdata/goosebit

Gunicorn can be configured by setting the GUNICORN_CMD_ARGS environment variable.

@easybe easybe force-pushed the gardena/eb/docker_image branch from 27798ad to 03f673d Compare August 27, 2024 08:52
@easybe easybe added the v0.2.0 label Aug 27, 2024
@b-rowan
Copy link
Collaborator

b-rowan commented Aug 27, 2024

What do you feel is missing here? I think this is a pretty good start from what I'm seeing, other than missing the docker compose...

@easybe easybe force-pushed the gardena/eb/docker_image branch from 03f673d to 20592f7 Compare August 27, 2024 21:35
@easybe easybe marked this pull request as ready for review August 27, 2024 21:36
@easybe
Copy link
Collaborator Author

easybe commented Aug 27, 2024

What do you feel is missing here? I think this is a pretty good start from what I'm seeing, other than missing the docker compose...

To answer your question: https://github.com/UpstreamDataInc/goosebit/compare/03f673d080d97994819baec1baefebef09b81aff..cc41c1f9bef09d23460dbf21224c5cf84ade147a

Docker Compose support will come after the release. We are dealing with a chicken-and-egg problem here.

Also, the CI part has not been thoroughly tested. We could just see what happens when we release though.

@easybe easybe requested a review from b-rowan August 27, 2024 21:46
@easybe easybe force-pushed the gardena/eb/docker_image branch from 20592f7 to cc41c1f Compare August 27, 2024 21:52
Copy link
Collaborator

@b-rowan b-rowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, I'll release a v0.2.0a1 when this is merged to test the build.

@easybe
Copy link
Collaborator Author

easybe commented Aug 27, 2024

I'll merge it tomorrow. I'll do some general testing first.

@easybe easybe force-pushed the gardena/eb/docker_image branch 2 times, most recently from a8e9df4 to 8bf4a3d Compare August 29, 2024 22:40
@easybe easybe requested a review from tsagadar August 30, 2024 06:56
@easybe easybe mentioned this pull request Aug 30, 2024
5 tasks
@easybe
Copy link
Collaborator Author

easybe commented Aug 30, 2024

@easybe easybe force-pushed the gardena/eb/docker_image branch 3 times, most recently from ddacd94 to c740481 Compare August 31, 2024 05:56
@b-rowan b-rowan added this to the v0.2.0 milestone Sep 3, 2024
@b-rowan b-rowan removed the v0.2.0 label Sep 3, 2024
@easybe easybe force-pushed the gardena/eb/docker_image branch 2 times, most recently from bfc413f to 2251272 Compare September 4, 2024 20:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Gunicorn can be configured by setting the GUNICORN_CMD_ARGS environment
variable.
On every release, a new image, containing the latest PyPI package, is
built and pushed to Docker Hub:
https://hub.docker.com/r/upstreamdata/goosebit
@easybe easybe force-pushed the gardena/eb/docker_image branch from 2251272 to 85e1522 Compare September 4, 2024 20:37
@easybe easybe merged commit 2da6967 into UpstreamDataInc:master Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants