-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker image #88
Add Docker image #88
Conversation
27798ad
to
03f673d
Compare
What do you feel is missing here? I think this is a pretty good start from what I'm seeing, other than missing the docker compose... |
03f673d
to
20592f7
Compare
To answer your question: https://github.com/UpstreamDataInc/goosebit/compare/03f673d080d97994819baec1baefebef09b81aff..cc41c1f9bef09d23460dbf21224c5cf84ade147a Docker Compose support will come after the release. We are dealing with a chicken-and-egg problem here. Also, the CI part has not been thoroughly tested. We could just see what happens when we release though. |
20592f7
to
cc41c1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, I'll release a v0.2.0a1
when this is merged to test the build.
I'll merge it tomorrow. I'll do some general testing first. |
a8e9df4
to
8bf4a3d
Compare
ddacd94
to
c740481
Compare
bfc413f
to
2251272
Compare
Gunicorn can be configured by setting the GUNICORN_CMD_ARGS environment variable.
On every release, a new image, containing the latest PyPI package, is built and pushed to Docker Hub: https://hub.docker.com/r/upstreamdata/goosebit
2251272
to
85e1522
Compare
On every release, a new image, containing the latest PyPI package, is built and pushed to Docker Hub:
https://hub.docker.com/r/upstreamdata/goosebit
Gunicorn can be configured by setting the GUNICORN_CMD_ARGS environment variable.