Version selection on package page #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, there's a problem. For some reason, using the search doesn't work correctly anymore. It takes you to a default link, but for some reason it isn't defaulting to latest. Refreshing the page does though, so it must be something about the way search navigates? |
|
Oh, it gets more interesting than that. Search works from the home page, but not when searching from a package page. |
|
Whoops, I had made it default when the state version was blank instead of the URL version. This meant it worked on a fresh page (ie: reload) but not page to page, like search. |
|
With this, the dependency links can now go to the correct version and not just the latest! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns the Version metadata into a dropdown, and allows users to inspect and install older versions.
Additionally, the URL will now include
?version=X.X.X, allowing users to share links that are guaranteed to always be a specific version. This may be useful for project documentation where a specific version of a package is necessary. Sharing a link with no version param will make it default to the latest version.The URL will remain up to date acc. to the user's selection, and supports back/forward navigation shortcuts. The addition of the latest version to a default link does not add a navigation waypoint, since there was no user action and should be silent.