Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#707 - Scunt Team Services Tests #715

Merged
merged 14 commits into from
Aug 22, 2023

Conversation

uzFer
Copy link
Contributor

@uzFer uzFer commented Aug 13, 2023

Contribution:

Issue:

Closes #707

Accomplishments:

  • Made tests for functions in ScuntTeamServices.js: updateLeaderTeam, getTeamPoints, getTeams, bribeTransaction, getScuntJudges, refillBribePoints, addTransaction, subtractTransaction, viewTransactions, checkTransaction, initializeTeams, deleteTransaction, viewRecentTransactions, and setTeamName.

Visuals:

n/a

Details:

Expected Behavior:

  • All tests should pass for the functions not commented out

Testing Steps:

  • Run docker command, cd server, yarn test
  • Check if all tests pass for ScuntTeamServices.test.js

Complications:

  • Some tests don't work for initializeTeams, bribeTransaction, and deleteTransaction (they are commented out)
  • Not sure how to test other logic for addTransaction where the assert checks for 'Updated to...' in the transaction

Resources:

n/a

@Freeassassin Freeassassin changed the title [DRAFT] #707 - Scunt Team Services Tests #707 - Scunt Team Services Tests Aug 22, 2023
@Freeassassin Freeassassin merged commit afcfe84 into 687-refactor-testing Aug 22, 2023
4 checks passed
@Freeassassin Freeassassin deleted the 707-scunt-team-services-tests branch August 22, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants