Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

698 - Bug in CSV Upload #709

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Conversation

Tanushanth
Copy link
Contributor

Contribution:

Issue:

Closes #698

Accomplishments:

  • Changes 'Items' key to 'Missions' in mapping parameter for parseCsvString within ScuntMissionsDashboard.jsx

Visuals:

image

Details:

Expected Behavior:

  • Head to /scunt-missions-dashboard with a leader account to upload a mission CSV of the following form: #,Mission,Category,Points,Hidden,Judging Station?
  • Should be able to preview and upload missions at this page

Testing Steps:

Steps required to get expected behavior.

  • With a leader account that has necessary scunt mission permissions (ex create), head to the mission panel under the scunt dropdown in the /profile page
  • Once at /scunt-missions-dashboard, head to the third tab (upload missions), and create a csv with missions with the following headers: #,Mission,Category,Points,Hidden,Judging Station?
  • Upload the csv, and click preview CSV, this should display the items in the table
  • After clicking this, the Upload Missions button will be functional

Complications:

  • Was not originally working for random reasons (length is undefined, etc). The Key in the mapping parameter in scuntMissionsDashboard.jsx just needed to be changed from Items to Missions (to match scuntMissionServices.jsx)

Resources:

Any additional resources used outside this in issue.

@Tanushanth Tanushanth linked an issue Aug 8, 2023 that may be closed by this pull request
2 tasks
@Tanushanth Tanushanth changed the title Small Change that was needed (Change Item -> Mission in the header) 698 - Bug in CSV Upload (Small Change) Aug 8, 2023
@Tanushanth Tanushanth changed the title 698 - Bug in CSV Upload (Small Change) 698 - Bug in CSV Upload Aug 12, 2023
@Freeassassin Freeassassin merged commit 09cb058 into dev Aug 14, 2023
3 checks passed
@Freeassassin Freeassassin deleted the 698-bugs-in-the-mission-csv-upload branch August 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in the mission csv upload?
2 participants